2.13.x migration and source compatibility


#1

We’ve been trying out 2.13.0-M4 for twitter util, and we have some feedback for scala implementors.

We have historically supported more than one scala version, which is useful for users who are trying to migrate from one version to another, so that they don’t have to both change their library version AND upgrade scala at the same time. However, scala 2.13.x seems to make it really hard to do this. Here are some of the issues we’ve run into when trying to migrate our first module:

  1. CanBuildFrom removed without a replacement is an issue for compatible source code between 2.11 and 2.13 (where type inference is enough)
  2. CanBuildFrom removed without a replacement is an issue for compatible source code between 2.12 and 2.13 (where type inference is not enough) e.g. Future.collect
  3. It’s risky to replace breakOut with views in 2.11 or 2.12 because we have low confidence in the correctness of views pre-2.13.
  4. ArrayBuffer no longer implements Seq, and no longer provides a result method. Nor does mutable.Buffer. We can call toSeq in every case, but we would rather not entail the extra copy, since this is sometimes on the hot path.
  5. Very clunky to convert a java.util.List to a Seq from java. JavaConverters.asScalaBuffer(list).iterator().toSeq())

Our understanding is that folks are writing scalafix tools to simplify migrating from 2.12 to 2.13, which is great! However, it would be even better if there was a happy medium where we didn’t need to maintain two versions of our source code. Is there any chance you can give us the tools we need to maintain source compatibility between 2.12 and 2.13?


#2

Hey @mosesn, thanks a lot for your feedback! Have you had a look at scala-collection-compat? It’s a library that provides a uniform syntax for collections usage on 2.11, 2.12 and 2.13.

It’s risky to replace breakOut with views in 2.11 or 2.12 because we have low confidence in the correctness of views pre-2.13.

This is a good point. The only solution I can think of is to replace xs.map(f)(breakOut): CC[A] with xs.iterator.map(f).to(CC). What do you think?

ArrayBuffer no longer implements Seq, and no longer provides a result method

It does implement Seq, what do you mean? There is no result method, but this method was previously returning this, so is this really blocking you?

Very clunky to convert a java.util.List to a Seq from java. JavaConverters.asScalaBuffer(list).iterator().toSeq())

It should be possible to just write list.asScala.toSeq. And if you don’t need an immutable.Seq (which is what the .toSeq method returns), you can just go with list.asScala, no?


#3

This is a good point. The only solution I can think of is to replace xs.map(f)(breakOut): CC[A] with xs.iterator.map(f).to(CC) . What do you think?

FWIW, all my pre 2.13 code used this idiom for anything lazy or any large stream of collection transformations. Views were broken, breakOut confuses those not familiar with it, and iterator just works, is lazy, and is fast.
I’m honestly still not sure what the purpose of views is when Iterator just works. It can’t be used more than once, but its usually simple to solve that problem client side. I’ve never ran into a use case where I actually needed a view.

2.13 views are just things that create iterators and produce collections now, so it can save me a few characters of typing every now and then.


#4

This is a good point. The only solution I can think of is to replace xs.map(f)(breakOut): CC[A] with xs.iterator.map(f).to(CC) . What do you think?

Yeah, that should work.

It does implement Seq , what do you mean? There is no result method, but this method was previously returning this , so is this really blocking you?

Yes, I guess result is not a big issue. However, I have needed to change a lot of code because of ArrayBuffer being different in 2.13. I might be confused about this, but here’s a diff that shows the kind of changes I had to make to get it to compile

diff --git a/util/util-core/src/main/scala/com/twitter/concurrent/AsyncStream.scala b/util/util-core/src/main/scala/com/twitter/concurrent/AsyncStream.scala
index a6d4b48..c6e52e7 100644
--- a/util/util-core/src/main/scala/com/twitter/concurrent/AsyncStream.scala
+++ b/util/util-core/src/main/scala/com/twitter/concurrent/AsyncStream.scala
@@ -508,15 +508,15 @@ sealed abstract class AsyncStream[+A] {
     def fillBuffer(
       sizeRemaining: Int
     )(s: => AsyncStream[A]): Future[(Seq[A], () => AsyncStream[A])] =
-      if (sizeRemaining < 1) Future.value((buffer, () => s))
+      if (sizeRemaining < 1) Future.value((buffer.toSeq, () => s))
       else
         s match {
-          case Empty => Future.value((buffer, () => s))
+          case Empty => Future.value((buffer.toSeq, () => s))

           case FromFuture(fa) =>
             fa.flatMap { a =>
               buffer += a
-              Future.value((buffer, () => empty))
+              Future.value((buffer.toSeq, () => empty))
             }

           case Cons(fa, more) =>

I wonder if I’m having issues around whether the default Seq is immutable.Seq vs collection.Seq? Regardless, it no longer works.

It should be possible to just write list.asScala.toSeq . And if you don’t need an immutable.Seq (which is what the .toSeq method returns), you can just go with list.asScala , no?

This doesn’t work for me from java. I think somehow mutable.Buffer loses toSeq when converting to java? I’m not sure exactly. Here’s an example of the kind of diff I’m thinking about

diff --git a/util/util-core/src/main/java/com/twitter/concurrent/Offers.java b/util/util-core/src/main/java/com/twitter/concurrent/Offers.java
index a26569b3..5917024 100644
--- a/util/util-core/src/main/java/com/twitter/concurrent/Offers.java
+++ b/util/util-core/src/main/java/com/twitter/concurrent/Offers.java
@@ -4,7 +4,7 @@ import com.twitter.util.Duration;
 import com.twitter.util.Function0;
 import com.twitter.util.Future;
 import com.twitter.util.Timer;
-import scala.collection.JavaConversions;
+import scala.collection.JavaConverters;
 import scala.runtime.BoxedUnit;

 import java.util.ArrayList;
@@ -60,7 +60,8 @@ public final class Offers {
    * @see Offer$#choose(scala.collection.Seq)
    */
   public static <T> Offer<T> choose(Collection<Offer<T>> offers) {
-    return Offer$.MODULE$.choose(JavaConversions.asScalaBuffer(new ArrayList<Offer<T>>(offers)));
+    return Offer$.MODULE$.choose(
+      JavaConverters.asScalaBuffer(new ArrayList<Offer<T>>(offers)).iterator().toSeq());
   }

   /**

#5

If your scala class is meant to be called from java, why not at have at least an overload that takes a java collection or array, and do the conversion on the scala side?


#6

Would that work for you to return a Future[(collection.Seq[A]), () => AsyncStream[A]] instead?

This would remove all the .toSeq calls.

Interesting. I think you are not the first one reporting that calling the Java converters from Java does not work seamlessly. This might be something we can improve…


#7

Java users often have trouble calling scala from java (exactly this kind of issue is a good example) so we typically make java shims when we think java users might run into issues. In fact, that’s exactly what we’re doing here: https://github.com/twitter/util/blob/develop/util-core/src/main/java/com/twitter/concurrent/Offers.java#L62. I think the specific reason why was because Offer is a trait, so it’s compiled down to being an interface in java, and interfaces and scala won’t compile static forwarders for interfaces. But we don’t always anticipate when java users will want to use an API, and frankly it seems like overkill to have to both make a java shim and make a java-friendly method in scala. I don’t think scala’s intent is for normal scala code to be so difficult to use from java anyway.


#8

Ah, I see. The default Seq in scala 2.13 changes from collection.Seq to collection.immutable.Seq? I think it’s unlikely that we’ll want to change our APIs to use non-default Seq, since it will be hard to remember that we need to special-case Seq. It’ll be nice to get the symmetry of all of the default collections being imutable.Seq–I didn’t even realize that Seq was collection.Seq.

However, this means that I don’t know what the efficient way of building up an immutable.Seq is. For Maps, we can use MapBuilder, is there a canonical SeqBuilder?


#9

It depends on the way you can build your Seq. We have a collection.immutable.ArraySeq that is very efficient in building a Seq if you know its size in advance (using ArraySeq.tabulate). Otherwise, the rule of thumb is to use Seq.newBuilder, which defaults to a List builder.


#10

Hi @mosesn,

I’m helping @julienrf with the migration by creating Scalafix rules. I would like to study the twitter-util diff. Can you push to a branch what you have so far? Thanks.


#11

Here’s what we did: