I agree this is a mess because the .toSet are dangling in the braceless variant. I opine that this mess started with what I think was an incorrect design decision for braced block as function parameters when a lambda and not a Unit.
I would have preferred instead (which if had been done consistently then a bijection between braces and blocks would have enable automatic tooling to help those who can’t read braceless):
val perCompanyOrNeutral: Set[AssetType] = Company.AllCompaniesAndNeutral
.flatMap company => {
companyDamAssetNames(company)
.map (level, assetName) => {
AssetType.Image(assetName, AssetPath(s"assets/dam$level-${company.stringID}.png"))
} .toSet
} .toSet
When there is chain of method calls, I argue the parentheses should be required because otherwise we’re repurposing braces to act as parentheses which is how Scala becomes so darn confusing with so many special cases. Please stop trying to be cute. This was the mistake Rust made also. Be regular in syntax and usage if you want to repair the reputation of Scala as an unnecessarily complicated language:
val perCompanyOrNeutral: Set[AssetType] = Company.AllCompaniesAndNeutral
.flatMap(company => {
companyDamAssetNames(company)
.map((level, assetName) => {
AssetType.Image(assetName, AssetPath(s"assets/dam$level-${company.stringID}.png"))
}).toSet
}).toSet
In which case we can drop the braces, so the utility of the braceless style returns. Tada problem solved!
val perCompanyOrNeutral: Set[AssetType] = Company.AllCompaniesAndNeutral
.flatMap(company =>
companyDamAssetNames(company)
.map((level, assetName) =>
AssetType.Image(assetName, AssetPath(s"assets/dam$level-${company.stringID}.png"))
).toSet
).toSet
I never have liked much Scala’s abstruse Haskell-like invocation of functions with spaces instead of parentheses. The feature can be useful rarely but I think should be discouraged in braceless style if we are indeed targeting the onboarding of junior programmers from Python. Function invocation with parentheses is more well understood. Okay there can be exceptions where it’s elegant to not employ paratheses so let’s not throw the baby out with the bathwater. But don’t get going in certain direction of attempting to minimize everything and be so cute that you tie yourself in knots and confuse the heck out of newbies. In short lean to regular syntax and usage please.